Make datastore search whitelist case insensitive#5969
Merged
amercader merged 2 commits intoMar 24, 2021
Merged
Conversation
Contributor
Author
|
I took the liberty of making the test module pass Flake8 checks while I was at it. |
Member
|
@ThrawnCA many thanks for this. We don't merge new branches to old release ones, all pull requests should target |
amercader
reviewed
Mar 23, 2021
df240dc to
08a8c31
Compare
Contributor
Author
Done. I've added a checklist entry for possible backporting. |
Member
|
Thanks @ThrawnCA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed fixes:
Make the datastore search SQL function whitelist case-insensitive, since PostgreSQL function calls are typically case-insensitive.
If case-sensitivity is desired, it can be achieved by enclosing a whitelist entry in "double quotes".
Features: