fix datastore_search language parameter#5974
Merged
wardi merged 2 commits intoMar 23, 2021
Merged
Conversation
Fixes ckan#5097 This was also causing the revamped datatablesview from working properly, as datastore_search always used the default language (english) and ignored the passed language parameter (simple), which allowed partial word matches and not just the snowball word stemming search.
amercader
added a commit
that referenced
this pull request
May 10, 2021
amercader
added a commit
that referenced
this pull request
May 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5097
This was also causing the revamped datatablesview from working properly, as
datastore_searchalways used the default language (english) and ignored the passed language parameter (simple), which allowed partial word matches and not just Snowball stemming search. (Snowball stemming search background)Fixing this will also make
datastore_searchresults in non-english languages more relevant, as it will use the proper Snowball dictionary for the specified language.Proposed fixes:
Fetch the language parameter using the right key - "language" as per the API docs and the validator, not "lang", as it was being used in the postgres backend.
Features:
Please [X] all the boxes above that apply