@wardi what's your opinion over this?

I have already put my research here

Thanks

@smotornyuk you updated this code in #5376 WDYT?

At a minimum it doesn't make sense to pass this to only one of the format_date/format_datetime calls.

@wardi Thanks for you reply.

In the template we are passing with_hours=True

If you have any suggestion, I m glad to fix it if needed

Thanks.

It doesn't sound quite right for me.. you are trying to fix consequences, not the source of the problem. Can you just set babel's default locale to the one, specified by ckan.display_timezone? Using BABEL_DEFAULT_TIMEZONE option of flask-babel

And yes, I think that all routes of localised_nice_date should return localized representation, not only with_hours=True.

hey @smotornyuk thanks for your reply

I just set the babel's default timezone to the one specified by ckan.display_timezone... working good when providing a timezone(e.g Europe/Zurich)

.. but when i set the value: server

i got this error pytz.exceptions.UnknownTimeZoneError: 'server'

Any suggestion?
Thanks

PS The source of the problem is because we didnt provide BABEL_DEFAULT_TIMEZONE (by default is set to UTC when no timezone provided)...so when we are calling format_datetime() by default rebasing happens and babel's get_timezone() returns UTC

So .. to prevent this...we can:
-pass rebase=False to all format_datetime()
or
-provide BABEL_DEFAULT_TIMEZONE value to the one specified by ckan.display_timezone (just keep on mind that when ckan.display_timezone is set to server we get this error: pytz.exceptions.UnknownTimeZoneError: 'server' )

What's your opinion over this?

There is a helper, get_display_timezone, that solves our issue with server value. in this special case it returns tzlocal.get_localzone() object. As any tzinfo object, this one has zone property that can be passed to the Babel's config.

So you can "unwrap" value of ckan.display_timezone here , right before babel is initialized

@smotornyuk Thanks for your help.

hey @wardi can you check my last PR? I did it as @smotornyuk suggest.

Thanks

Hey @wardi it's me again 😊 can you please check my PR ?

Thanks

@smotornyuk I'll have to rely on you again, does this seem like a sensible flask config change?

Yep. I would say that it's the only right way to configure flask-babel timezone in CKAN)