Fix unpriviledged users being able to access bulk process#6290
Closed
f-osorio wants to merge 3 commits into
Closed
Fix unpriviledged users being able to access bulk process#6290f-osorio wants to merge 3 commits into
f-osorio wants to merge 3 commits into
Conversation
Any user was able to access and view the bulk process page for organization management. This fix checks access and returns unauthorized exception if theuser shouldn't be there.
Member
|
I see that the post-handler of the same view uses the |
Previously implementation only worked for GET requests, now works with GET and POST requests
Author
Right, I'll get that in soon. |
Was using group_update. Also removed duplicate check from POST request
Member
|
As we need it for backport, i've fixed tests in a new PR #6346 |
smotornyuk
added a commit
that referenced
this pull request
Aug 30, 2021
…accessing-bulk-process [#6290] prevent unauth user accessing bulk process [test fix]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Any user was able to access and view the bulk process page for organization
management. This fix checks access and returns unauthorized exception
if theuser shouldn't be there.
Fixes #
Proposed fixes:
Added
check_accessforgroup updateand a catch statement forNotAuthorized