[6521]Upload.__init__ relies too much on makedirs#6578
Merged
amercader merged 3 commits intoDec 20, 2021
Merged
Conversation
kowh-ai
approved these changes
Dec 16, 2021
Contributor
kowh-ai
left a comment
There was a problem hiding this comment.
Iv'e tested this change on all possible iterations I can think of...looks good to me
ThrawnCA
reviewed
Jan 6, 2022
| raise | ||
| # check if the storage directory is already created by | ||
| # the user or third-party | ||
| if os.path.isdir(self.storage_path): |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6521
Proposed fixes:
Features:
Please [X] all the boxes above that apply