Refactor DomainObjectModificationExtension to support SQLAlchemy 1.4#6699
Merged
amercader merged 11 commits intoFeb 18, 2022
Merged
Conversation
amercader
added a commit
that referenced
this pull request
Feb 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of #6243
Proposed fixes:
Removes deprecated SqlAlchemy's SessionExtension.
To do that, it is needed a small refactor on the DomainObjectModificationExtension to not implement the ISession interface, but rather call it's
before_commitfunction with SqlAlchemyevent_listeners.The DomainObjectModificationExtension is currently used by:
It is an over engineered solution and should be simplified but it is out of the scope of this work (Migrate SQLAlchemy to 1.4)
Deprecation
This PR will deprecate ISession interface since it's no longer the paradigm to extend SQLAlchemy events.