Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[#4933] Fix Norwegian translation#6746

Merged
amercader merged 3 commits into
masterfrom
4933-fix-no-translation
Mar 17, 2022
Merged

[#4933] Fix Norwegian translation#6746
amercader merged 3 commits into
masterfrom
4933-fix-no-translation

Conversation

@amercader
Copy link
Copy Markdown
Member

Fixes #4933

@frafra This PR is a follow up from our discussion in #6725

In this approach, I've copied the existing no translation on Transifex and copied it to a new nb_NO language and renamed the i18n folder in the CKAN source.
I've also added a redirect for /no/ URLs to /nb_NO/

Do you think this is the most sensible approach?
This will probably break sites that are currently using no in the ckan.locale_default config option. We can mention that in the CHANGELOG, or is it worth exploring keeping a symlink no -> nb_NO for compatibility?

TODO on Transifex:

  • @frafra I've made you a manager of this language, would you mind inviting the existing users from no over to nb_NO?
  • Shall I delete the existing no language on Transifex?

@amercader amercader added this to the CKAN 2.10 milestone Mar 15, 2022
@frafra
Copy link
Copy Markdown
Contributor

frafra commented Mar 15, 2022

@amercader Invitations sent.
I think we can remove the no language.

@amercader amercader self-assigned this Mar 15, 2022
@amercader amercader merged commit 2d4fc20 into master Mar 17, 2022
@amercader amercader deleted the 4933-fix-no-translation branch March 17, 2022 12:33
@amercader
Copy link
Copy Markdown
Member Author

Thanks @frafra

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Norwegian language is not working with Flask blueprints

2 participants