Clean old c attribute from helpers.py#6765
Merged
tino097 merged 6 commits intoMar 31, 2022
Merged
Conversation
tino097
reviewed
Mar 25, 2022
Member
Author
|
@tino097 I've added the removal file to the changes folder :) |
MarkCalvert
reviewed
Aug 3, 2023
| @@ -1,4 +1,4 @@ | |||
| {% set tags = h.get_facet_items_dict('tags', c.search_facets, limit=3) %} | |||
| {% set tags = h.get_facet_items_dict('tags', search_facets, limit=3) %} | |||
There was a problem hiding this comment.
FYI This always returns no tags because search_facets does not exist because it is not being set in the extra_vars object passed to this template from the blueprint home.index.
Member
Author
There was a problem hiding this comment.
Thanks @MarkCalvert ! Would you like to create a PR fixing it? :)
There was a problem hiding this comment.
Sure. We will add it to our list to contribute back a PR.
Member
There was a problem hiding this comment.
This was fixed in 2.10 dev branch but i didnt added the labels for backports
#7519
Member
|
@amercader this PR shoudl be included in 2.10.2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
cobject is a legacy attribute that adds noise and complexity to our code base. While working with Pylons, thecobject was used a lot to store variables needed when rendering templates. Currently we have theextra_varsdict so some of the changes is to explicitly pass the variable to the snippets and do not rely on it being magically stored in thecobject.This PR cleans its usage in the
helpers.pymodule.Changes
c->gsince currently we proxy the valuesearch_facetsparameters to remove the dependency onc.search_facets