Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Backport: add auth functions for 18 actions that didn't have them before#7045

Merged
tino097 merged 24 commits into
ckan:dev-v2.9from
berlinonline:backport/add_missing_auth_functions
Sep 8, 2022
Merged

Backport: add auth functions for 18 actions that didn't have them before#7045
tino097 merged 24 commits into
ckan:dev-v2.9from
berlinonline:backport/add_missing_auth_functions

Conversation

@knudmoeller
Copy link
Copy Markdown
Contributor

@knudmoeller knudmoeller commented Aug 25, 2022

This PR is a backport of #7042 for the 2.9 branch.

Fixes #

Proposed fixes:

  • Add auth functions for 18 GET-able API methods.
  • Call the new auth functions from the corresponding action functions.

All new auth functions return {"success": True}. Now that they are present, they can be changed by plugin developers to fine-tune authorization.

Features:

  • includes tests covering changes
  • includes updated documentation
  • includes user-visible changes
  • includes API changes
  • includes bugfix for possible backport

Please [X] all the boxes above that apply

amercader and others added 20 commits October 20, 2020 11:57
`--config` isn't a valid option to `rebuild`
Also provide better logs so that it is possible to identify the issue.
Catch TypeError from invalid dates thrown by dateutils
…-date

Revert "Catch TypeError from invalid dates thrown by dateutils"
Update ckan (paster) commands for ckan 2.9.x
…a-creation-issues

[6802]Fix test data creation issues
@knudmoeller knudmoeller changed the title add auth functions for 17 actions that didn't have them before Backport: add auth functions for 17 actions that didn't have them before Aug 25, 2022
@knudmoeller knudmoeller changed the title Backport: add auth functions for 17 actions that didn't have them before Backport: add auth functions for 18 actions that didn't have them before Aug 25, 2022
@amercader
Copy link
Copy Markdown
Member

@knudmoeller Backports should be submitted against the dev-v2.9 branch, can you rebase please?

@knudmoeller knudmoeller changed the base branch from 2.9 to dev-v2.9 September 6, 2022 13:21
@knudmoeller
Copy link
Copy Markdown
Contributor Author

@amercader No problem. Should I trigger a re-run for the tests on CircleCI?

@amercader
Copy link
Copy Markdown
Member

@knudmoeller it won't hurt :)

@knudmoeller
Copy link
Copy Markdown
Contributor Author

knudmoeller commented Sep 6, 2022

@amercader Looks like I'm not authorized to do that. I have logged in to CircleCI, but then I get a "You need permissions to trigger a build". :(

@tino097
Copy link
Copy Markdown
Member

tino097 commented Sep 6, 2022

I can do it, as i need to review this PR
But looks good from first impresion

Copy link
Copy Markdown
Member

@tino097 tino097 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tino097 tino097 merged commit 7acb612 into ckan:dev-v2.9 Sep 8, 2022
@knudmoeller knudmoeller deleted the backport/add_missing_auth_functions branch September 13, 2022 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants