Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix activity stream icons#7169

Merged
amercader merged 8 commits into
ckan:masterfrom
pdelboca:fix-activity-stream-icons
Nov 9, 2022
Merged

Fix activity stream icons#7169
amercader merged 8 commits into
ckan:masterfrom
pdelboca:fix-activity-stream-icons

Conversation

@pdelboca
Copy link
Copy Markdown
Member

@pdelboca pdelboca commented Nov 2, 2022 •
edited
Loading

Fixes part of #6840

Proposed fixes:

  • Update the activity stream icons to Font-Awesome: https://fontawesome.com/docs/web/style/stack
  • Some small CSS and HTML cleanup to reduce complexity
  • Add the pull-right class to the activity to fix the Activity Filter alignment
  • Move all activity CSS files to the extension folder.

image

Test failure unrelated:

=========================== short test summary info ============================
FAILED ckan/tests/cli/test_user.py::TestApiToken::test_revoke - AssertionErro...
==== 1 failed, 725 passed, 1 skipped, 2173 deselected in 626.20s (0:10:26) =====

Exited with code exit status 1

@pdelboca pdelboca added this to the CKAN 2.10 milestone Nov 3, 2022
@amercader amercader self-assigned this Nov 3, 2022
@amercader amercader merged commit f7ddbf6 into ckan:master Nov 9, 2022
@amercader amercader mentioned this pull request Dec 1, 2022
Closed
@pdelboca
Copy link
Copy Markdown
Member Author

pdelboca commented Jan 19, 2023

I'm removing the Backport 2.10.0 label since it is already done.

@pdelboca pdelboca mentioned this pull request Jan 20, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@amercader amercader

Labels

None yet

Projects

None yet

Milestone

CKAN 2.10

Development

Successfully merging this pull request may close these issues.

2 participants

@pdelboca @amercader