Thanks to visit codestin.com
Credit goes to github.com

Skip to content

dataset publish/unpublish buttons, error handling#8309

Merged
smotornyuk merged 12 commits into
masterfrom
8308-draft-publish
Apr 9, 2025
Merged

dataset publish/unpublish buttons, error handling#8309
smotornyuk merged 12 commits into
masterfrom
8308-draft-publish

Conversation

@wardi
Copy link
Copy Markdown
Contributor

@wardi wardi commented Jul 1, 2024

address some of #8308

Proposed fixes:

  • Consistent display of draft state across dataset pages
  • Error handling is now done on publish, so validators that only apply certain rules to fields for published datasets (e.g. required-only-when-published) will be properly displayed instead of causing a server error.
  • templates/package/new_package_form.html content has been merged into its parent template templates/package/snippets/package_form.html and is now marked as deprecated

This PR changes the "Save" button on the current theme draft dataset editing interface to "Publish":
Screenshot from 2025-03-28 16-58-08
This brings it in line with the new theme:
Screenshot from 2025-03-28 16-55-43

It also adds the "Unpublish" feature (move a dataset back to draft state) to the current theme:
Screenshot from 2025-03-29 15-10-21
Already available in the new theme:
Screenshot from 2025-03-29 15-08-25

Features:

  • includes tests covering changes
  • includes updated documentation
  • includes user-visible changes
  • includes API changes
  • includes bugfix for possible backport

@wardi wardi changed the title dataset draft publish buttons, error handling dataset draft publish/unpublish buttons, error handling Mar 29, 2025
@wardi wardi marked this pull request as ready for review March 29, 2025 19:24
@wardi wardi changed the title dataset draft publish/unpublish buttons, error handling dataset publish/unpublish buttons, error handling Mar 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants