Fix is_organization for custom organization type schema#437
Merged
Conversation
Member
|
@avdata99 looks good but I would add a nice verbose comment over that line. This touches on some poorly documented behaviors of CKAN so a simple |
pdelboca
reviewed
Mar 4, 2025
Co-authored-by: Patricio Del Boca <[email protected]>
Member
Author
|
This is probably ready to go @pdelboca |
Member
|
@wardi any feedback or suggestions on this PR? I'm not sure how to handle the release cycle of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CKAN core defines as default
is_organization = Falsefor theIGroupFormhttps://github.com/ckan/ckan/blob/master/ckan/plugins/interfaces.py#L1352
Also, CKAN check is a group is an
organizationusing this propertyhttps://github.com/ckan/ckan/blob/master/ckan/lib/plugins.py#L223-L226
CKAN group index views at
ckan/views/group.indexuses thisis_organizationproperty.If a custom
organization_typeis defined with a schema file throughckanext-schemingwe need to ensureis_organization = TrueThis PR fixes this.
Also, to release 3.0.1 is proposed. A new tag
release-3.0.1is requiredAlso, GitHub action fixed