Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix missing grpc register of query for dyncomm#380

Merged
fragwuerdig merged 6 commits into
mainfrom
dyncomm-grpc-fix
Nov 8, 2023
Merged

fix missing grpc register of query for dyncomm#380
fragwuerdig merged 6 commits into
mainfrom
dyncomm-grpc-fix

Conversation

@StrathCole

Copy link
Copy Markdown
Collaborator

Summary of changes

added query to grpc

(FOR ADMIN) Before merging

  • Added appropriate labels to PR
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Confirm added tests are consistent with the intended behavior of changes
  • Ensure all tests pass

@fragwuerdig

Copy link
Copy Markdown
Collaborator

The regeneration of market/oracle/treasury types should not be part of this PR...

@StrathCole

Copy link
Copy Markdown
Collaborator Author

The regeneration of market/oracle/treasury types should not be part of this PR...

Sure. Will revert that commit later and only commit the relevant.
I think depending on the version of protoc you have, it generates different proto go files. Technically the same, but different coding style. 😔

@StrathCole

Copy link
Copy Markdown
Collaborator Author

@fragwuerdig Reverted and added only changed query proto files. Update on rebel-2 validator worked.

@fragwuerdig fragwuerdig merged commit 56037e7 into main Nov 8, 2023
@fragwuerdig fragwuerdig deleted the dyncomm-grpc-fix branch November 8, 2023 20:35
@fragwuerdig

Copy link
Copy Markdown
Collaborator

Happy With This - Thanks @StrathCole

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants