Thanks to visit codestin.com
Credit goes to github.com

Skip to content

add dynamic commission acc seq fix#386

Merged
nghuyenthevinh2000 merged 5 commits into
mainfrom
fix-dyncomm
Nov 26, 2023
Merged

add dynamic commission acc seq fix#386
nghuyenthevinh2000 merged 5 commits into
mainfrom
fix-dyncomm

Conversation

@nghuyenthevinh2000

@nghuyenthevinh2000 nghuyenthevinh2000 commented Nov 24, 2023

Copy link
Copy Markdown
Contributor

Summary of changes

Report of required housekeeping

  • Github issue OR spec proposal link
  • Wrote tests
  • Updated API documentation (client/lcd/swagger-ui/swagger.yaml)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]

(FOR ADMIN) Before merging

  • Added appropriate labels to PR
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Confirm added tests are consistent with the intended behavior of changes
  • Ensure all tests pass

StrathCole
StrathCole reviewed Nov 24, 2023
View reviewed changes
Comment thread types/fork/fork.go Outdated
@basitalikhoso110

basitalikhoso110 commented Nov 24, 2023

Copy link
Copy Markdown

fix-dyncomm

fragwuerdig
fragwuerdig approved these changes Nov 25, 2023
View reviewed changes

@fragwuerdig fragwuerdig left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that looks good from my side.

My suggestion would be to introduce a "legacy" dyncomm ante decorator that only runs the dyncomm ante handler for "<" specified block height. The normal one would run for ">=" specified block height.

This way the chain could be forked without explicitly halting the chain.

@StrathCole

StrathCole commented Nov 25, 2023

Copy link
Copy Markdown
Collaborator

I think that looks good from my side.

My suggestion would be to introduce a "legacy" dyncomm ante decorator that only runs the dyncomm ante handler for "<" specified block height. The normal one would run for ">=" specified block height.

This way the chain could be forked without explicitly halting the chain.

I think the validators complained about not having a proposal for notifying them about the update, so maybe a proposal with chain halt is the best way to make sure they all see it.

@nghuyenthevinh2000 nghuyenthevinh2000 merged commit a0a38c3 into main Nov 26, 2023
@nghuyenthevinh2000 nghuyenthevinh2000 deleted the fix-dyncomm branch November 26, 2023 09:36
expertdicer pushed a commit to Genuine-labs/terra-classic that referenced this pull request Jan 28, 2024
@nghuyenthevinh2000 @expertdicer
add dynamic commission acc seq fix (classic-terra#386)
05d25fc
expertdicer pushed a commit to Genuine-labs/terra-classic that referenced this pull request Jan 28, 2024
@nghuyenthevinh2000 @expertdicer
add dynamic commission acc seq fix (classic-terra#386)
a435487
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StrathCole StrathCole StrathCole left review comments

@fragwuerdig fragwuerdig fragwuerdig approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nghuyenthevinh2000 @basitalikhoso110 @StrathCole @fragwuerdig