Remove QTKit for Xcode 8 / macOS 10.12 Sierra #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QTKit was deprecated some time ago and then removed altogether in favor of AVFoundation.
Fortunately this didn't require too many drastic changes. I just kept looking at the modified method signatures across AVCaptureDeviceInput, AVCaptureSession, and other classes while making appropriate tweaks.
I tested this on my MacBook running Sierra. Although I'm unable to easily run the standard sanity-test
camera.testme()due to its dependence on qtwidget/qtlua -> Qt 4, I did a full test with torch + a browser + my built-in webcam using vfonov/deep-pi modified for macOS.It was only after going through most of this exercise did I realize that when OpenCV is available, one can run on Sierra with the entire camera.m implementation omitted. I have tweaked the CMake configuration to make it install with only one or the other (camopencv or cammacos), but not both.
If you build OpenCV locally, note that at a minimum it requires configuration settings such as
-DBUILD_opencv_objdetect:BOOL=ON-DBUILD_opencv_photo:BOOL=ON-DBUILD_opencv_video:BOOL=ON-DBUILD_opencv_videoio:BOOL=ONand headaches are likely minimized via-DBUILD_SHARED_LIBS:BOOL=OFF.