Thanks to visit codestin.com
Credit goes to github.com

Skip to content

New Icon component #2120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 9, 2025
Merged

New Icon component #2120

merged 7 commits into from
Oct 9, 2025

Conversation

NWylynko
Copy link
Contributor

@NWylynko NWylynko commented Mar 20, 2025 •
edited
Loading

🔎 Previews:

What does this solve?

  • Currently we are loading icons twice on the page, firstly clerk.com loads them, then secondly they are loaded in as partials

What changed?

  • In this pr https://github.com/clerk/clerk/pull/1083 I have introduced a new <Icon /> component that exposes the icons we are using in the partials.
  • In this pr I have updated the markdown to use the <Icon /> component

Checklist

  • I have clicked on "Files changed" and performed a thorough self-review
  • I have added the "deploy-preview" label and added the preview link(s) to this PR description
  • All existing checks pass

@NWylynko NWylynko requested a review from a team as a code owner March 20, 2025 16:33
@github-actions GitHub Actions
Copy link
Contributor

Hey, here’s your docs preview: https://clerk.com/docs/pr/2120

@github-actions GitHub Actions
Copy link
Contributor

⚠️ Changes found in the following quickstarts:

  • overview.mdx

⚠️ Please update the corresponding quickstarts in the Dashboard

@NWylynko NWylynko changed the title Nick/switch to icon component [blocked] New Icon component Mar 20, 2025
@vercel Vercel
Copy link

vercel bot commented Oct 6, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
clerk-docs Ready Ready Preview Oct 9, 2025 1:25pm

@NWylynko NWylynko changed the title [blocked] New Icon component New Icon component Oct 9, 2025
alexisintech
alexisintech approved these changes Oct 9, 2025
View reviewed changes
Copy link
Member

@alexisintech alexisintech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this optimization, awesome idea nick 😸💖

@alexisintech alexisintech merged commit 3ad73ac into main Oct 9, 2025
7 checks passed
@alexisintech alexisintech deleted the nick/switch-to-icon-component branch October 9, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexisintech alexisintech alexisintech approved these changes

Assignees

No one assigned

Labels

Blocked deploy-preview

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@NWylynko @alexisintech