Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore(clerk-js,types): Handle pending sessions as signed-out in isSignedIn for custom flows #5505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 2, 2025
Merged

chore(clerk-js,types): Handle pending sessions as signed-out in isSignedIn for custom flows #5505

merged 2 commits into from
Apr 2, 2025

Conversation

@LauraBeatris
Copy link
Member

@LauraBeatris LauraBeatris commented Apr 1, 2025 •
edited
Loading

Description

Part of ORGS-621

Clerk.isSignedIn will return false by default if the Clerk.session.status === pending. This will make it easier for custom flows migration when force-an-org gets enabled by default on a instance:

const clerk = new Clerk(pubKey)
await clerk.load()

// Only mounts UI that relies on the user object, if the session switches to 'active'
if (clerk.isSignedIn) {
  clerk.mountUserButton(userbuttonDiv)
} else {
 // ......
}

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@LauraBeatris LauraBeatris self-assigned this Apr 1, 2025
@changeset-bot
Copy link

changeset-bot bot commented Apr 1, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: fafeb8e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Apr 1, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 2, 2025 9:24am

@LauraBeatris LauraBeatris force-pushed the laura/clerk-signed-in-pending branch from f1c270a to b5370f7 Compare April 1, 2025 22:31
@clerk-cookie clerk-cookie removed the react label Apr 1, 2025
@LauraBeatris LauraBeatris force-pushed the laura/clerk-signed-in-pending branch 2 times, most recently from 2f2fc89 to b826373 Compare April 1, 2025 22:32
@clerk-cookie clerk-cookie removed the types label Apr 1, 2025
@LauraBeatris LauraBeatris force-pushed the laura/clerk-signed-in-pending branch from 26337c5 to 3a9e5d8 Compare April 2, 2025 09:04
@LauraBeatris LauraBeatris force-pushed the laura/clerk-signed-in-pending branch from 3a9e5d8 to dadc95f Compare April 2, 2025 09:21
@LauraBeatris LauraBeatris force-pushed the laura/clerk-signed-in-pending branch from dadc95f to fafeb8e Compare April 2, 2025 09:23
@LauraBeatris LauraBeatris marked this pull request as ready for review April 2, 2025 09:42
@LauraBeatris LauraBeatris requested a review from a team April 2, 2025 09:42
This was referenced Apr 2, 2025
Merged
Merged
@LauraBeatris LauraBeatris merged commit 243b153 into main Apr 2, 2025
32 checks passed
@LauraBeatris LauraBeatris deleted the laura/clerk-signed-in-pending branch April 2, 2025 18:22
@clerk-cookie clerk-cookie mentioned this pull request Apr 2, 2025
Merged
@coderabbitai coderabbitai bot mentioned this pull request Jul 29, 2025
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@panteliselef panteliselef panteliselef approved these changes

Assignees

@LauraBeatris LauraBeatris

Labels

clerk-js types

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@LauraBeatris @panteliselef @clerk-cookie