chore(nextjs): Add support for pages router when verifying webhooks #5618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: e6a0538 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Member
Author
|
!snapshot |
Collaborator
|
Hey @wobsoriano - the snapshot version command generated the following package versions:
Tip: Use the snippet copy button below to quickly install the required packages. npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact |
…rifywebhook-request-param-by
wobsoriano
commented
Apr 14, 2025
Comment on lines
+50
to
+57
| export async function verifyWebhook(request: RequestLike, options?: VerifyWebhookOptions) { | ||
| if (isNextRequest(request) || isRequestWebAPI(request)) { | ||
| return verifyWebhookBase(request, options); | ||
| } | ||
|
|
||
| const webRequest = nextApiRequestToWebRequest(request); | ||
| return verifyWebhookBase(webRequest, options); | ||
| } |
Member
Author
There was a problem hiding this comment.
For standard web Request, it uses the default verifyWebhook provided by the backend SDK. For NextApiRequest type, we're converting it to a Request before verifying
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Recently, we added a way to simplify webhook verification across our SDKs. While this works for all SDKs that provides a standard web
Request, there are still users who use Next.js Pages Router or frameworks like tRPC that use Node'sIncomingMessageinstead of webRequest. This PR adds support for webhook verification with these frameworks by accepting a RequestLike request, accepting both standard webRequestand Node Request.Resolves ECO-571
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change