chore(clerk-js): Hide Billing tabs from UP and OP when no paid plans exist for an instance #5628
Conversation
…exist for an instance
🦋 Changeset detectedLatest commit: a5c3eb2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 22 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| {experimental?.commerce && | ||
| __experimental_commerceSettings.billing.enabled && | ||
| __experimental_commerceSettings.billing.hasPaidUserPlans && ( | ||
| <Route path={isBillingPageRoot ? undefined : 'billing'}> |
There was a problem hiding this comment.
Just a note that this will have a conflict if the user enables commerce and has a custom page with the billing route.
There was a problem hiding this comment.
Wouldn't be better to have user-billing, also it will follow the same pattern we have with orgs route
There was a problem hiding this comment.
Thanks for putting this on the spotlight. I started an internal discussion, we can do a follow up PR once we settle on the approach.
Description
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change