fix(clerk-js): Disambiguate redirect url options between flows #5645
Conversation
🦋 Changeset detectedLatest commit: e509648 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| const redirectUrls = new RedirectUrls( | ||
| options, | ||
| { | ||
| ...ctx, |
There was a problem hiding this comment.
doesn't this mean that SignInContext and SignUpContext still contain a forceRedirectUrl prop? Can we completely remove any and all usage of forceRedirectUrl except at the component boundary?
There was a problem hiding this comment.
I'll remove from the context, as far as I can tell forceRedirectUrl isn't actually used outside of this assignment in the components, so we should be safe.
|
would you mind adding a test for the "render sign in modal, click sign up, sign up with existing account" flow with the props specified? |
|
@dstaley done! |
Description
Fixes an issue where
fallbackRedirectUrlandforceRedirectUrlpassed to a specific flow would be improperly passed to the other flow in a modal case.Example:
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change