Use consistent slice ordering in run download tests #10006
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no suggestions.
Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more
andyfeller
approved these changes
Dec 4, 2024
Member
andyfeller
left a comment
There was a problem hiding this comment.
Oof, yeah makes sense with map being inconsistent 🤦 Thanks for knocking this out!
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Dec 6, 2024
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [cli/cli](https://github.com/cli/cli) | patch | `v2.63.1` -> `v2.63.2` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>cli/cli (cli/cli)</summary> ### [`v2.63.2`](https://github.com/cli/cli/releases/tag/v2.63.2): GitHub CLI 2.63.2 [Compare Source](cli/cli@v2.63.1...v2.63.2) #### What's Changed - Use consistent slice ordering in run download tests by [@​williammartin](https://github.com/williammartin) in cli/cli#10006 - Fix bug when fetching bundles from OCI registry by [@​malancas](https://github.com/malancas) in cli/cli#10019 - Use safepaths for run download by [@​williammartin](https://github.com/williammartin) in cli/cli#10009 - Error for mutually exclusive json and watch flags by [@​andyfeller](https://github.com/andyfeller) in cli/cli#10016 **Full Changelog**: cli/cli@v2.63.1...v2.63.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #10005
Implementation
The previous implementation was relying on the iteration order of a map when responding with a list of test artifacts from the
fakePlatform, which resulted in flakiness. This PR makes use of a slice instead.