Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: error when head and base refs are identical in pr create #12376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
majiayu000 wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

fix: error when head and base refs are identical in pr create #12376

majiayu000 wants to merge 1 commit into from
+113 −0

Conversation

@majiayu000
Copy link

@majiayu000 majiayu000 commented Dec 26, 2025

Summary

When gh pr create is invoked with head and base refs pointing to the same ref in the same repository, the command now returns an error instead of proceeding with an invalid PR creation.

This addresses the issue where running gh pr create from the base branch (e.g., main) would accidentally push commits to main.

Changes

  • Added isSameRef() helper function to check if head and base point to identical refs
  • Added validation in createRun() that errors early when refs are identical
  • Cross-repository PRs (e.g., from forks) with the same branch name continue to work

Test plan

  • Added unit tests for isSameRef() function covering:
    • Same branch in same repo (should error)
    • Different branches in same repo (should work)
    • Same branch name in different repos/forks (should work)
  • Added integration tests in Test_createRun for the error case
  • All existing tests pass

Fixes #11903

@majiayu000
fix: error when head and base refs are identical in pr create
9daa22e 
When a user runs `gh pr create` with head and base refs pointing to
the same ref in the same repository, the command now exits with an
error instead of proceeding with an invalid PR creation.

This prevents accidental pushes to the main branch and provides clear
feedback when users attempt to create a PR from the base branch.

Cross-repository PRs (e.g., from forks) with the same branch name
continue to work as expected.

Fixes cli#11903

Signed-off-by: majiayu000 <[email protected]>
@majiayu000 majiayu000 requested a review from a team as a code owner December 26, 2025 11:14
@majiayu000 majiayu000 requested a review from BagToad December 26, 2025 11:14
@cliAutomation cliAutomation added the external pull request originating outside of the CLI core team label Dec 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BagToad BagToad Awaiting requested review from BagToad BagToad is a code owner automatically assigned from cli/code-reviewers

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

external pull request originating outside of the CLI core team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

gh pr create should warn or abort when run from the base branch (e.g., main)

2 participants

@majiayu000 @cliAutomation