Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix non-TTY gh issue view --comments output for zero-comment issues #13482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sergiou87 wants to merge 1 commit into from
+70 −7
Closed

Fix non-TTY gh issue view --comments output for zero-comment issues #13482

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions pkg/cmd/issue/view/view.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,15 +186,10 @@ func viewRun(opts *ViewOptions) error {
return printHumanIssuePreview(opts, baseRepo, issue)
}

if opts.Comments {
fmt.Fprint(opts.IO.Out, prShared.RawCommentList(issue.Comments, api.PullRequestReviews{}))
return nil
}

return printRawIssuePreview(opts.IO.Out, issue)
return printRawIssuePreview(opts.IO.Out, issue, opts.Comments)
}

func printRawIssuePreview(out io.Writer, issue *api.Issue) error {
func printRawIssuePreview(out io.Writer, issue *api.Issue, includeComments bool) error {
assignees := issueAssigneeList(*issue)
labels := issueLabelList(issue, nil)
projects := issueProjectList(*issue)
Expand Down Expand Up @@ -234,6 +229,10 @@ func printRawIssuePreview(out io.Writer, issue *api.Issue) error {
fmt.Fprintf(out, "number:\t%d\n", issue.Number)
fmt.Fprintln(out, "--")
fmt.Fprintln(out, issue.Body)
if includeComments && len(issue.Comments.Nodes) > 0 {
fmt.Fprintln(out, "--")
fmt.Fprint(out, prShared.RawCommentList(issue.Comments, api.PullRequestReviews{}))
}
return nil
}

Expand Down
64 changes: 64 additions & 0 deletions pkg/cmd/issue/view/view_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -487,6 +487,12 @@ func TestIssueView_nontty_Comments(t *testing.T) {
mockEmptyV2ProjectItems(t, r)
},
expectedOutputs: []string{
`title:\tsome title`,
`state:\tOPEN`,
`author:\tmarseilles`,
`comments:\t6`,
`number:\t123`,
`some body`,
`author:\tmonalisa`,
`association:\t`,
`edited:\ttrue`,
Expand All @@ -509,6 +515,64 @@ func TestIssueView_nontty_Comments(t *testing.T) {
`Comment 5`,
},
},
"with comments flag and no comments": {
cli: "123 --comments",
httpStubs: func(r *httpmock.Registry) {
r.Register(
httpmock.GraphQL(`query IssueByNumber\b`),
httpmock.JSONResponse(map[string]any{
"data": map[string]any{
"repository": map[string]any{
"hasIssuesEnabled": true,
"issue": map[string]any{
"number": 123,
"title": "some title",
"body": "some body",
"state": "OPEN",
"createdAt": "2020-01-01T12:00:00Z",
"author": map[string]any{
"login": "marseilles",
},
"assignees": map[string]any{
"nodes": []any{},
"totalCount": 0,
},
"labels": map[string]any{
"nodes": []any{},
"totalCount": 0,
},
"projectItems": map[string]any{
"nodes": []any{},
"totalCount": 0,
},
"milestone": map[string]any{
"title": "",
},
"comments": map[string]any{
"nodes": []any{},
"totalCount": 0,
"pageInfo": map[string]any{
"hasNextPage": false,
"endCursor": nil,
},
},
"url": "https://github.com/OWNER/REPO/issues/123",
},
},
},
}),
)
mockEmptyV2ProjectItems(t, r)
},
expectedOutputs: []string{
`title:\tsome title`,
`state:\tOPEN`,
`author:\tmarseilles`,
`comments:\t0`,
`number:\t123`,
`some body`,
},
},
"with invalid comments flag": {
cli: "123 --comments 3",
wantsErr: true,
Expand Down
Loading