Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: honor --pin when --force is specified on extension install #13602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AruneshDwivedi wants to merge 1 commit into
base: trunk
Choose a base branch
from
+9 −1
Open

fix: honor --pin when --force is specified on extension install #13602

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion pkg/cmd/extension/command.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,8 +378,16 @@ func NewCmdExtension(f *cmdutil.Factory) *cobra.Command {

if ext, err := checkValidExtension(cmd.Root(), m, repo.RepoName(), repo.RepoOwner()); err != nil {
// If an existing extension was found and --force was specified, attempt to upgrade.
// However, if --pin is also set, we should reinstall with the pin rather than
// upgrading, since the user explicitly requested a specific version.
if forceFlag && ext != nil {
return upgradeFunc(ext.Name(), forceFlag)
if pinFlag != "" {
if err := m.Remove(ext.Name()); err != nil {
return err
}
} else {
return upgradeFunc(ext.Name(), forceFlag)
}
}

if errors.Is(err, alreadyInstalledError) {
Expand Down