Bump Go to 1.27.1 - #14423
Closed
github-actions[bot] wants to merge 1 commit into
Closed
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The Go 1.27 syntax crashes the pinned govulncheck CI tool, and dependent workflow and prerequisite versions remain stale.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Updates GitHub CLI to Go 1.27.1 and applies Go 1.27 source modernizations.
Changes:
- Raises the Go directive/toolchain and golangci-lint version.
- Migrates error handling to
errors.AsTypeand reverse iteration toslices.Backward. - Applies promoted-field composite literals and related
go fixcleanups.
File summaries
| File | Description |
|---|---|
.github/golangci-lint-version |
Updates golangci-lint. |
go.mod |
Requires Go 1.27.0/1.27.1. |
api/client.go |
Modernizes error matching. |
api/queries_repo.go |
Modernizes GraphQL error matching. |
git/client_test.go |
Modernizes test error matching. |
git/command.go |
Modernizes exit-error matching. |
internal/codespaces/codespaces.go |
Modernizes timeout matching. |
internal/codespaces/connection/tunnels_api_server_mock.go |
Simplifies embedded-field initialization. |
internal/config/migration/multi_account.go |
Modernizes configuration error matching. |
internal/ghcmd/cmd.go |
Modernizes top-level error dispatch. |
internal/run/run.go |
Modernizes process error matching. |
internal/skills/discovery/discovery.go |
Modernizes release error matching. |
internal/skills/installer/installer.go |
Modernizes traversal-error matching. |
internal/zip/zip.go |
Modernizes traversal-error matching. |
pkg/cmd/attestation/api/client.go |
Modernizes retry error matching. |
pkg/cmd/attestation/artifact/oci/client.go |
Modernizes transport error matching. |
pkg/cmd/attestation/artifact/oci/client_test.go |
Simplifies test initialization. |
pkg/cmd/attestation/verification/attestation.go |
Modernizes path-error matching. |
pkg/cmd/attestation/verification/extensions_test.go |
Simplifies certificate initialization. |
pkg/cmd/attestation/verification/mock_verifier.go |
Simplifies mock certificate initialization. |
pkg/cmd/auth/status/status.go |
Modernizes missing-scope matching. |
pkg/cmd/cache/delete/delete.go |
Modernizes HTTP error matching. |
pkg/cmd/codespace/ssh.go |
Modernizes iteration and string splitting. |
pkg/cmd/extension/command.go |
Modernizes extension error matching. |
pkg/cmd/gist/create/create.go |
Modernizes HTTP error matching. |
pkg/cmd/issue/edit/edit_test.go |
Simplifies embedded test fields. |
pkg/cmd/issue/shared/lookup.go |
Modernizes GraphQL error matching. |
pkg/cmd/pr/create/create.go |
Uses Go 1.27 iteration and literals. |
pkg/cmd/pr/create/create_test.go |
Simplifies embedded test fields. |
pkg/cmd/pr/edit/edit_test.go |
Simplifies embedded test fields. |
pkg/cmd/project/shared/queries/queries.go |
Modernizes GraphQL error matching. |
pkg/cmd/release/create/create.go |
Modernizes workflow-scope error matching. |
pkg/cmd/release/shared/upload.go |
Modernizes retry error matching. |
pkg/cmd/repo/create/create.go |
Modernizes process error matching. |
pkg/cmd/repo/delete/delete.go |
Modernizes HTTP error matching. |
pkg/cmd/repo/gitignore/view/view.go |
Modernizes HTTP error matching. |
pkg/cmd/repo/license/view/view.go |
Modernizes HTTP error matching. |
pkg/cmd/repo/sync/http.go |
Modernizes HTTP error matching. |
pkg/cmd/repo/sync/sync.go |
Modernizes synchronization error matching. |
pkg/cmd/root/alias.go |
Modernizes alias exit-error matching. |
pkg/cmd/root/extension.go |
Modernizes extension exit-error matching. |
pkg/cmd/run/cancel/cancel.go |
Modernizes HTTP error matching. |
pkg/cmd/run/delete/delete.go |
Modernizes HTTP error matching. |
pkg/cmd/run/download/download.go |
Modernizes traversal-error matching. |
pkg/cmd/skills/install/install.go |
Modernizes discovery error matching. |
pkg/cmd/skills/list/list.go |
Uses reverse slice iteration. |
pkg/cmd/ssh-key/list/list.go |
Modernizes HTTP error matching. |
pkg/cmd/status/status.go |
Modernizes GraphQL error matching. |
pkg/cmd/workflow/disable/disable.go |
Modernizes filtered-workflow matching. |
pkg/cmd/workflow/enable/enable.go |
Modernizes filtered-workflow matching. |
pkg/cmd/workflow/run/run.go |
Modernizes filtered-workflow matching. |
pkg/cmd/workflow/shared/shared.go |
Modernizes HTTP error matching. |
pkg/iostreams/iostreams.go |
Uses reverse iteration for pager environment cleanup. |
Review details
- Files reviewed: 53/53 changed files
- Comments generated: 3
- Review effort level: Balanced
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+863
to
+864
| baseRepo: baseRepo, | ||
| baseBranchName: baseBranch, |
Comment on lines
+3
to
+5
| go 1.27.0 | ||
|
|
||
| toolchain go1.26.8 | ||
| toolchain go1.27.1 |
| module github.com/cli/cli/v2 | ||
|
|
||
| go 1.26.0 | ||
| go 1.27.0 |
6 tasks
Member
|
Closing for #14428 to kick off the next one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates Go to the latest stable release.
1.27.0go1.27.1v2.13.2