Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

JasonAtClockwork
Copy link
Contributor

@JasonAtClockwork JasonAtClockwork commented Sep 3, 2025

Description of Changes

Closes #3219
This adds the Unreal SDK, the new Unreal test cases, updates the test runner to handle Unreal, codegen updates for Unreal, and a QuickStart Chat.

API and ABI breaking changes

No breaking changes.

Expected complexity level and risk

2 - This impacts the subcommand generate.rs to include unrealcpp and crates/testing to expand for Unreal

Testing

  • Run the new Unreal tests
  • Run any previous automation testing - with all the changes to generate/testing I'm uncertain if there is an impact
  • Review the new CLI generate documentation changes

@bfops bfops force-pushed the jlarabie/unreal-sdk-initial branch from 081c3c2 to fba4744 Compare September 10, 2025 19:43
JasonAtClockwork and others added 11 commits September 10, 2025 13:54
# Conflicts:
#	crates/cli/src/subcommands/generate.rs
… + .cpp generation for Unreal

Added FrameTick() for SpacetimeDbSdk to match the C# version
Fixed Reauth test to store the token outside of UCredentials
# Description of Changes

## Before merging this
1. uncomment the part of the workflow file that overrides `GIT_REF`.
This was causing me issues during testing because it somehow kept
pulling back in a rolled-back commit from the base branch, but I suspect
that this will no longer be true once new commits are added to the base
branch.
1. connect a proper GitHub account to an Epic Games account
(specifically, an account that multiple people have access to, e.g.
maybe all of our devops team)
2. set the `GHCR_SECRET` GH action secret in this repo to be a
long-lived PAT for a different account
(https://github.com/clockworklabs/SpacetimeDB/settings/secrets/actions).
**The current token will expire soon.**
3. Make this check required, I think.

# API and ABI breaking changes

None. CI-only changes.

# Expected complexity level and risk

2

# Testing
- [x] The CI runs and seems to pass!

---------

Co-authored-by: Zeke Foppa <[email protected]>
Co-authored-by: John Detter <[email protected]>
@JasonAtClockwork
Copy link
Contributor Author

@bfops - With cargo test --all and this new Unreal set of tests the Test Suites will keep failing. I've updated all the Unreal tests to start with unreal_ to allow for --skip unreal but I'm not sure we should change the Test Suites to --skip unreal?

@bfops
Copy link
Collaborator

bfops commented Sep 18, 2025

@bfops - With cargo test --all and this new Unreal set of tests the Test Suites will keep failing. I've updated all the Unreal tests to start with unreal_ to allow for --skip unreal but I'm not sure we should change the Test Suites to --skip unreal?

Looks like you've already done it but yes I think we should add --skip-unreal to all the test suites that currently use --all

@JasonAtClockwork JasonAtClockwork marked this pull request as ready for review September 18, 2025 17:59
Copy link
Collaborator

@bfops bfops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my code-owned file (crates/cli/src/subcommands/generate.rs) LGTM, but left several optional nits.

Copy link
Collaborator

@jdetter jdetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm reviewing the docs for this now. I think this is ready to go in for now and we can fix issues in follow-up PRs as this PR is already quite large and hard to review.

@JasonAtClockwork JasonAtClockwork added this pull request to the merge queue Sep 19, 2025
Merged via the queue into master with commit 26e99fe Sep 19, 2025
26 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Unreal Support
4 participants