Add example of using clj-time to description of the current-date recipe #253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
This paragraph might not be necessary. We use clj-time in a bunch of other places and where it warrants introduction we will probably keep it light in the recipes and drop a note in the introduction.
|
I dropped two suggestions for improvement in comments, otherwise I'm glad you added this. |
|
Sounds good. Will update the pull request tonight with those changes. |
Some people prefer to use the Joda-Time objects instead of Java's Date objects for dealing with dates and times. Provide an example in the description of how one can use clj-time to interact with Joda-Time objects in addition to the solution that covers Java Date objects.
Allow for copy/pasting into the repl, as well as align with output from other examples in the book.
Allow for copy/pasting into the REPL, as well as match other code excerpts in the book.
|
Updated based off feed back above, and did a rebase of the changes from master of clojure-cookbook/clojure-cookbook. |
qtrfeast
pushed a commit
that referenced
this pull request
Oct 1, 2013
Add example of using clj-time to description of the current-date recipe
|
Thanks!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.