Fix invalid ignore pattern for underscore files#233
Merged
bourdakos1 merged 2 commits intocloud-annotations:mainfrom Nov 28, 2022
Merged
Conversation
✅ Deploy Preview for docusaurus-openapi ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Member
|
Is GlobExcludeDefault used anywhere else? Can we just add |
Contributor
Author
|
True! That should work just fine 👌 |
bourdakos1
approved these changes
Nov 28, 2022
Member
|
Hmm it looks like the demo isn’t picking up the I didn’t realize the default glob is coming directly from Docusaurus, so maybe they changed their glob in a newer version? |
Contributor
Author
|
That's a mystery for me, I checked the file history that contains the GlobIgnore pattern, it has never changed 🤔 I'll investigate and let you know |
Contributor
Author
|
It's this pattern Let's just not rely on |
cefef96 to
de90201
Compare
de90201 to
49c1d15
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was discussed here: #107 (comment)
Closes #232