vmm: warn about deprecation of default IP address + mask - #7179
Merged
likebreath merged 1 commit intoJul 8, 2025
Merged
likebreath merged 1 commit into
likebreath merged 1 commit into
Conversation
Issue: cloud-hypervisor#7083 Signed-off-by: Maximilian Güntner <[email protected]>
Contributor
Author
|
When adding a new net device using Should I add a corresponding logger? This may be unexpected behavior for users as currently no logs are printed at all besides the result of the command. |
likebreath
approved these changes
Jul 7, 2025
Member
I think that's a good idea. Would you please open a follow-up PR for that? Thank you. |
mguentner
added a commit
to mguentner/cloud-hypervisor
that referenced
this pull request
Sep 22, 2025
This change enables easier integration with third-party tools by removing the requirement for a dummy IP address when configuring tap devices. The modification applies to both CLI and API interactions. Previously, cloud-hypervisor would automatically set a default static IP address (192.168.249.1) if none was provided. This could lead to: * multiple devices without explicit IP configurations would end up with the same default IP * unnecessary inclusion of this IP in firewall rules * the IP address could clash with host networking and routing This introduces a new constraint: When providing an IP, the mask must also be provided. Removes warnings introduced in cloud-hypervisor#7179. Closes issue cloud-hypervisor#7083. Signed-off-by: Maximilian Güntner <[email protected]>
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Sep 22, 2025
This change enables easier integration with third-party tools by removing the requirement for a dummy IP address when configuring tap devices. The modification applies to both CLI and API interactions. Previously, cloud-hypervisor would automatically set a default static IP address (192.168.249.1) if none was provided. This could lead to: * multiple devices without explicit IP configurations would end up with the same default IP * unnecessary inclusion of this IP in firewall rules * the IP address could clash with host networking and routing This introduces a new constraint: When providing an IP, the mask must also be provided. Removes warnings introduced in #7179. Closes issue #7083. Signed-off-by: Maximilian Güntner <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #7083
The location of the
warn!statements cover bothNetConfig::parseandNetConfigcreation via deserialization usingserde.Preparation for a PR like #7076 in a few releases.