Thanks to visit codestin.com
Credit goes to github.com

Skip to content

vmm: Drop 'vfio container' when no active vfio devices - #7364

Merged
likebreath merged 1 commit into
cloud-hypervisor:mainfrom
likebreath:0917/properly_drop_vfio_container
Oct 10, 2025
Merged

vmm: Drop 'vfio container' when no active vfio devices#7364
likebreath merged 1 commit into
cloud-hypervisor:mainfrom
likebreath:0917/properly_drop_vfio_container

Conversation

@likebreath

@likebreath likebreath commented Sep 17, 2025

Copy link
Copy Markdown
Member

This provides clearer life-cycle management of resources around vfio, and aligns better with the kernel behavior as reported below with vfio legacy mode (with vfio container/group).

Fixes: #7328

@likebreath
likebreath requested a review from a team as a code owner September 17, 2025 23:06
@likebreath likebreath mentioned this pull request Sep 17, 2025
Closed
@likebreath
likebreath force-pushed the 0917/properly_drop_vfio_container branch from d0b507b to 5590ebe Compare September 17, 2025 23:12
up2wing
up2wing reviewed Sep 18, 2025
View reviewed changes
Comment thread vmm/src/device_manager.rs Outdated
@up2wing

up2wing commented Sep 18, 2025

Copy link
Copy Markdown
Contributor

Would you please add the tags in commit message? Thanks.

Reported-by: Yi Wang [email protected]
Tested-by: Yi Wang [email protected]

@likebreath

likebreath commented Sep 18, 2025

Copy link
Copy Markdown
Member Author

I'd like to ask @up2wing to take over. Close it for now.

@likebreath likebreath closed this Sep 18, 2025
@up2wing up2wing reopened this Sep 19, 2025
@up2wing

up2wing commented Sep 19, 2025

Copy link
Copy Markdown
Contributor

I'd like to ask @up2wing to take over. Close it for now.

The PR look good to me, please continue to work on this. @likebreath

Thanks a lot.

@likebreath
likebreath force-pushed the 0917/properly_drop_vfio_container branch from 5590ebe to 0fe91bd Compare October 7, 2025 22:21
@likebreath

likebreath commented Oct 7, 2025

Copy link
Copy Markdown
Member Author

Would you please add the tags in commit message? Thanks.

Reported-by: Yi Wang [email protected] Tested-by: Yi Wang [email protected]

@up2wing Appreciate the patience. I addressed the comment above and the clippy issue. It should be ready for review.

I also added the signed-off-by on your behalf to the commit message since your contribution is substantial to this patch. Please let me know if you prefer the Reported-by and Tested-by tag.

Thank you.

@up2wing

up2wing commented Oct 8, 2025

Copy link
Copy Markdown
Contributor

Would you please add the tags in commit message? Thanks.
Reported-by: Yi Wang [email protected] Tested-by: Yi Wang [email protected]

@up2wing Appreciate the patience. I addressed the comment above and the clippy issue. It should be ready for review.

I also added the signed-off-by on your behalf to the commit message since your contribution is substantial to this patch. Please let me know if you prefer the Reported-by and Tested-by tag.

Thank you.

The PR looks good to me. Thanks a lot.

@likebreath
likebreath added this pull request to the merge queue Oct 8, 2025
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 8, 2025
@likebreath likebreath mentioned this pull request Oct 8, 2025
Closed
3 tasks
@rbradford
rbradford added this pull request to the merge queue Oct 9, 2025
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 9, 2025
@likebreath @rbradford
vmm: Drop 'vfio container' when no active vfio devices
afeffe2 
This provides clearer life-cycle management of resources around vfio,
and aligns better with the kernel behavior as reported below with vfio
legacy mode (with vfio container/group).

Fixes: cloud-hypervisor#7328

Signed-off-by: Bo Chen <[email protected]>
Signed-off-by: Yi Wang <[email protected]>
@rbradford
rbradford force-pushed the 0917/properly_drop_vfio_container branch from 0fe91bd to afeffe2 Compare October 9, 2025 16:23
@rbradford

rbradford commented Oct 9, 2025

Copy link
Copy Markdown
Member

I just did a rebase of this to pick up CI changes.

@rbradford
rbradford enabled auto-merge October 9, 2025 16:24
@rbradford
rbradford added this pull request to the merge queue Oct 9, 2025
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 9, 2025
@likebreath
likebreath added this pull request to the merge queue Oct 9, 2025
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 9, 2025
@likebreath
likebreath added this pull request to the merge queue Oct 9, 2025
Merged via the queue into cloud-hypervisor:main with commit 256f0c3 Oct 10, 2025
40 checks passed
@up2wing up2wing mentioned this pull request Nov 5, 2025
Closed
up2wing added a commit to up2wing/cloud-hypervisor that referenced this pull request Nov 5, 2025
@up2wing
vmm: fix concurrent access issue of vfio_container
d6506e6 
The vfio_container can be accessed both in
mmio_write() -> cleanup_vfio_container() and add_device(),
which are two threads. It's safe to add a lock to ensure
consistency.

Fixes: cloud-hypervisor#7364

Signed-off-by: Yi Wang <[email protected]>
@likebreath likebreath added the bug-fix Bug fix to include in release notes label Nov 6, 2025
@likebreath likebreath moved this to ✅ Done in Cloud Hypervisor Roadmap Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rbradford rbradford rbradford approved these changes
@up2wing up2wing up2wing approved these changes

Assignees

No one assigned

Labels

bug-fix Bug fix to include in release notes

Projects

Cloud Hypervisor Roadmap
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

nvidia-smi fails after hotplug/unplug

3 participants

@likebreath @up2wing @rbradford