arch: Handle amx related features in subleaf 0x1 of leaf 0x7 - #7496
Closed
olivereanderson wants to merge 1 commit into
Closed
olivereanderson wants to merge 1 commit into
olivereanderson wants to merge 1 commit into
Conversation
phip1611
approved these changes
Nov 21, 2025
The Intel Granite Rapids processors include more AMX related features that are advertised in leaf 0x7 subleaf 0x1. If the VM is not configured to support AMX (the default) then these feature bits need to be masked out. This is addressed by this PR. Signed-off-by: Oliver Anderson <[email protected]> On-behalf-of: SAP <[email protected]>
olivereanderson
force-pushed
the
leaf-0x7-subleaf-1-amx-masking
branch
from
November 21, 2025 14:39
ffee01e to
9681f22
Compare
tpressure
suggested changes
Nov 21, 2025
Member
There was a problem hiding this comment.
@olivereanderson I think this is still not enough. Looking at the most recent spec, we probably also need to wipe leaf 0x1d (tile information leaf) and leaf 0x1e (TMUL information main leaf) including all their subleafs :(
It is really unfortunate that Intel spread this information across so many leafs.
phip1611
requested changes
Nov 21, 2025
phip1611
left a comment
Member
There was a problem hiding this comment.
Will approve when our CPUID leaf expert @tpressure gives a 👍🏻
Contributor
Author
|
Closed in favour of #7508 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Intel Granite Rapids processors include more AMX related features that are advertised in leaf 0x7 subleaf 0x1.
If the VM is not configured to support AMX (the default) then these feature bits need to be masked out. This is addressed by this PR.