virtio-devices: Do not close an unowned FD - #7679
Merged
rbradford merged 1 commit intoFeb 11, 2026
Merged
Conversation
DemiMarie
force-pushed
the
no-double-close-simple
branch
from
February 10, 2026 00:10
9d40305 to
2e4d552
Compare
Member
|
All the other tests for dpdk live migration are disabled referencing #5532. I'd approve this PR with a commit that disables this failing test referencing an issue. I think this fix is clearly the right thing. There may need to be some extra fixes around migration but this currently crashing out so needs to be addressed ASAP. |
Instead of closing a file descriptor that belongs to the vhost-user frontend, drop the vu_common_ctrl::VhostUserHandle and the vhost::vhost_user::Frontend it contains. This causes the destructor to drop the file descriptor. This breaks the last DPDK test, so disable it. See cloud-hypervisor#7689. Fixes: cloud-hypervisor#7163 Signed-off-by: Demi Marie Obenour <[email protected]>
DemiMarie
force-pushed
the
no-double-close-simple
branch
from
February 10, 2026 21:33
2e4d552 to
b600449
Compare
Contributor
Author
Done! Filed #7689 for the broken live migration, and also referenced #5532. |
rbradford
approved these changes
Feb 11, 2026
DemiMarie
added a commit
to DemiMarie/cloud-hypervisor
that referenced
this pull request
Feb 12, 2026
All but one of them has been broken for over 2 years (issue cloud-hypervisor#5532), and the last one is broken (issue cloud-hypervisor#7689) by a critical bug fix (PR cloud-hypervisor#7679). There is no point in having broken tests in the repository, so delete them. They can be restored from git history if necessary. Signed-off-by: Demi Marie Obenour <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of closing a file descriptor that belongs to the vhost-user frontend, drop the vu_common_ctrl::VhostUserHandle and the vhost::vhost_user::Frontend it contains. This causes the destructor to drop the file descriptor.