Accept multi-descriptor TX packets in vsock - #7680
Merged
Merged
Conversation
liuw
force-pushed
the
vsock-large-packets
branch
3 times, most recently
from
February 10, 2026 01:07
9586743 to
e0f1e6c
Compare
phip1611
reviewed
Feb 10, 2026
phip1611
left a comment
Member
There was a problem hiding this comment.
Code-wise LGTM. Unfortunately, I don't have sufficient domain background to review this aspect in depth.
rbradford
approved these changes
Feb 10, 2026
Since kernel commit 6693731487a8 ("vsock/virtio: Allocate nonlinear SKBs
for handling large transmit buffers"), a large vsock packet can be split
into multiple descriptors.
If we encounter such TX packets, pull the content into an owned buffer.
Fixes: cloud-hypervisor#7672
Signed-off-by: Wei Liu <[email protected]>
liuw
force-pushed
the
vsock-large-packets
branch
from
February 10, 2026 16:11
e0f1e6c to
13a5d9b
Compare
Member
Author
|
Thank you for the comments. I will merge this myself. I need to ask my contact to test this upstream version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is reported that Kata UVM sends large TX packets which are broken into multiple data descriptors. The current implementation is broken.
This patch only handles the guest TX path. RX path is left to another day.
Fixes: #7672