vmm: Fix CPU's nested control on AMD - #7783
Merged
rbradford merged 2 commits intoMar 4, 2026
Merged
Conversation
rbradford
commented
Mar 4, 2026
Member
- arch: x86_64: Correctly disable nested virtualization on AMD
- tests: Add integration test for nested virtualization
sboeuf
approved these changes
Mar 4, 2026
sboeuf
left a comment
Member
There was a problem hiding this comment.
LGTM! Just two typos in the commit message introducing the fix.
The loop that is for programming the APIC ID and disabling nested virtualization was prematurely breaking out on AMD platforms as the 0x1 leaf is also valid on AMD. This lead to the code attempting to disable SVM in the 0x8000_0001 leaf never being reached. Now only break out early if the CPU vendor is Intel. Signed-off-by: Rob Bradford <[email protected]>
Since we run integration tests on Intel & AMD this should test the
behaviour of `--cpus nested={on|off}` correctly.
Signed-off-by: Rob Bradford <[email protected]>
rbradford
force-pushed
the
202603/fix-amd-nested-cpuid
branch
from
March 4, 2026 12:23
8e35a5b to
d0fc0d6
Compare
rbradford
enabled auto-merge
March 4, 2026 12:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.