Conversation
phip1611
left a comment
There was a problem hiding this comment.
lovely! Less flakiness and maybe even one-two minutes less execution time!
|
(This whole PR is a bit speculative as i'm still working on running the tests locally.) |
43c045e to
64bf50c
Compare
| /// Waits until the guest's SSH port is no longer reachable, indicating | ||
| /// the guest has fully shut down. |
There was a problem hiding this comment.
Does it really indicate that the guest has fully shut down? It just means sshd has been stopped and the guest could still be shutting down/cleaning up other things?
There was a problem hiding this comment.
Yeh, it's a tricky one. Suggest a better name?
There was a problem hiding this comment.
If this is just about if the guest shut down: why not check the event monitor?
There was a problem hiding this comment.
Because it doesn't poweroff the VM - instead it just halts it. Thus you don't get the event. This is for a test that boots, shutdown and then boots it again. I guess if it used poweroff then it would quit the VMM and that wouldn't work.
There was a problem hiding this comment.
What about wait_for_ssh_unresponsive() ? And then maybe when #8025 lands we can do better?
There was a problem hiding this comment.
UPDATE You were faster than me haha
by the way, we are going to change that #8025 - guest shutdown will keep the VMM running. Not sure if this is helpful for you here (I don't know the specifics)
Okay, my long weekend starts now - see you Monday!
There was a problem hiding this comment.
We can keep the current name. I was just wondering if this is the most reliable way we have for determining if a guest has shut down. Seems like that is the case currently. So be it then.
64bf50c to
5a31235
Compare
Use new `wait_until()` and existing boot response mechanisms to remove explicit sleeps from these tests. Signed-off-by: Rob Bradford <[email protected]>
Use the new `wait_until()` to test the balloon size. Signed-off-by: Rob Bradford <[email protected]>
If we're about to kill the daemons we don't need to spin waiting for them. Signed-off-by: Rob Bradford <[email protected]>
Rather than use a fixed time to wait for the socket to be opened instead test for its existence using `wait_until()`. Signed-off-by: Rob Bradford <[email protected]>
The vhost-user tests uses SSH and checking the RAM to test for the liveness of the VM - replace the explicit sleep before them with `wait_until()` allowing them to potentially finish earlier. Signed-off-by: Rob Bradford <[email protected]>
On the shutdown path remove the explicit sleep and instead wait for the event to be delivered. Signed-off-by: Rob Bradford <[email protected]>
Instead use `wait_until()` for mounting of the filesystem. Signed-off-by: Rob Bradford <[email protected]>
Use `wait_until()` with the SSH command for detecting if the block device is present/absent as part of hotplugging/unplugging. Signed-off-by: Rob Bradford <[email protected]>
Use `wait_until()` with the SSH command for detecting if the net device is present/absent as part of hotplugging/unplugging. Signed-off-by: Rob Bradford <[email protected]>
Instead wait for the event to be delivered that it has panicked. Signed-off-by: Rob Bradford <[email protected]>
Instead wait for the guest to stop responding on the SSH port. Signed-off-by: Rob Bradford <[email protected]>
5a31235 to
5ef8633
Compare
43b5a47
wait_until!to check for vhost-user socket