Conversation
KSM will not attempt to merge pages that are mapped as MAP_SHARED, so configuring memory with both mergeable and shared options is invalid. Add validation to reject configurations where both options are enabled for memory or memory zones. Signed-off-by: Rob Bradford <[email protected]>
phip1611
approved these changes
May 4, 2026
btwiuse
pushed a commit
to btwiuse/snix
that referenced
this pull request
Jun 19, 2026
- address clippy lints - regenerate proto bindings - only set shared=on for //snix/boot (cloud-hypervisor/cloud-hypervisor#8126) Change-Id: Id7dcb84be3998899e34a1ae9fc6db69aab4c953f Reviewed-on: https://cl.snix.dev/c/snix/+/31308 Tested-by: besadii Reviewed-by: Ilan Joselevich <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KSM will not attempt to merge pages that are mapped as MAP_SHARED, so
configuring memory with both mergeable and shared options is invalid.
Add validation to reject configurations where both options are enabled
for memory or memory zones.
Signed-off-by: Rob Bradford [email protected]