vmm: add explicit PCI BDF support for Rng device - #8163
Merged
Merged
Conversation
phip1611
marked this pull request as draft
May 7, 2026 13:57
phip1611
commented
May 7, 2026
| @@ -1750,23 +1750,25 @@ impl NetConfig { | |||
| } | |||
|
|
|||
| impl RngConfig { | |||
| pub const SYNTAX: &'static str = | |||
| "Random number generator parameters \"src=<path:/dev/urandom>,pci_device_id=<pci_slot>\""; | |||
Member
Author
There was a problem hiding this comment.
open question. should I advertise pci_segment here or not? Technically it is supported by the parsing logic but I am not sure if it would work.
We (@cyberus-technology) do not need support for this. We just need pci_device_id
phip1611
force-pushed
the
upstream-bdf-rng
branch
2 times, most recently
from
May 7, 2026 14:34
2a0c74a to
c97e82e
Compare
phip1611
marked this pull request as ready for review
May 7, 2026 14:38
scholzp
approved these changes
May 7, 2026
Member
Author
|
@rbradford it would be lovely if we can get this merged before the upcoming v52 release. I think it is fairly uncontroversial and a nice fix/feature |
rbradford
reviewed
May 8, 2026
rbradford
left a comment
Member
There was a problem hiding this comment.
lgtm, We can definitely land this soon.
This was referenced May 8, 2026
rbradford
approved these changes
May 8, 2026
| } | ||
|
|
||
| impl RngConfig { | ||
| // We ignore `id` and `pci_segment` as we use hard-coded internal defaults for now. |
Member
There was a problem hiding this comment.
Is this comment still accurate?
Member
Author
There was a problem hiding this comment.
Yikes, will remove it. Thank!
Member
|
Sorry @phip1611 i'd missed you'd updated this PR today. I wonder if GH is having notification issues. |
This was missing in [0] but is required for proper explicit PCI BDF management, e.g., when a VM is created via libvirt and each device has an explicit BDF. [0] cloud-hypervisor#7965 On-behalf-of: SAP [email protected] Signed-off-by: Philipp Schuster <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was missing in [0] but is required for proper explicit PCI BDF management, e.g., when a VM is created via libvirt and each device has an explicit BDF. Also important for live migration.
Without this, the BDF could change after a live migration, due to implicit BDF allocation! Further, management software wants full control over PCI BDFs.
[0] #7965