vmm: Disable sector 0 writes for autodetected VHD images - #8218
Merged
likebreath merged 1 commit intoMay 14, 2026
Merged
Conversation
When no image_type is specified, sector 0 writes are disabled as a safety measure for autodetected raw images. Extend this protection to autodetected fixed VHD images, which carry metadata in the last sector and are equally susceptible to accidental overwrites of the first sector when the format is not explicitly acknowledged. Update the corresponding warning in the virtio block worker to be format agnostic. Signed-off-by: Anatol Belski <[email protected]>
likebreath
approved these changes
May 14, 2026
likebreath
enabled auto-merge
May 14, 2026 16:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When no image_type is specified, sector 0 writes are disabled as a safety measure for autodetected raw images. Extend this protection to autodetected fixed VHD images, which carry metadata in the last sector and are equally susceptible to accidental overwrites of the first sector when the format is not explicitly acknowledged.
Update the corresponding warning in the virtio block worker to be format agnostic.