vmm: Deprecate image type auto detection - #8219
likebreath merged 1 commit into
Conversation
Signed-off-by: Bo Chen <[email protected]>
|
I want to flag that live upgrade from pre-v51.0 would likely be broken at the time when the auto-detection feature is removed in a future release, as pre-v51.0 does not have |
| warn!( | ||
| "DEPRECATION: auto-detection of disk image type is deprecated and will be \ | ||
| removed in a future release. Please specify image type explicitly." | ||
| ); | ||
|
|
There was a problem hiding this comment.
I feel like we should only warn when we autodetected to non-RAW?
There was a problem hiding this comment.
Hmm, if our plan is to make image_type a required field in a future release, why is RAW a special case that shouldn't get a deprecation warning?
There was a problem hiding this comment.
IMHO having a warning on all seems consistent, since image_type will become mandatory regardless of format.
There was a problem hiding this comment.
On the other hand, with no automatic and absence of image_type, it can fallback to RAW, could be a possibility, too. But in that case, would seem still ok to be verbose to attract attention to the fact. Thanks
|
I was working on the assumption that most people use raw image files so therefore we shouldn't require |
|
I don't think there is an need to change the wording in this PR - but we should continue the conversation. If the consensus is to always require |
Yeah. That would be cleaner (perhaps safer) to me, always require explicit image type, including RAW. |
b4b9982
No description provided.