vmm: openapi: Fix integer schema formats - #8278
Merged
Merged
Conversation
Member
|
@segfaultmedaddy Please review CONTRIBUTING.md (and look at the changes to the same file to correctly identify the commit message style. This is a best practice for all open source projects you might be committing to for the first time. |
The current OpenAPI schema format is wrong because uint16 and uint32 are not valid top-level OpenAPI types. Describe queue_size and virtio_id as integer types with explicit uint formats instead. Signed-off-by: Roman <[email protected]>
Contributor
Author
|
Hey @rbradford. I have updated the commit message according to the guideline. LMK if anything else needs correction |
phip1611
approved these changes
May 26, 2026
rbradford
approved these changes
May 27, 2026
Member
|
@segfaultmedaddy All good - thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running oapi-codegen against the current schema is failing on the wrong formatting of the types for the queue_size and virtio_id fields. This PR resolves the issue.