logger: cache local timezone before seccomp - #8327
Merged
Merged
Conversation
dgreid
force-pushed
the
topic/tz-cache
branch
2 times, most recently
from
June 3, 2026 17:47
6b2c772 to
e2e202d
Compare
Local-time log fields called `jiff::Zoned::now()`, which resolves the system timezone on every record by reading `/etc/localtime`/`/etc/timezone` if it doesn't hit the cached version. This cache miss could then cause a seccomp violation depending on the thread it was run from. Avoid this by capturing the value in `Logger`. This avoids opening the seccomp filter for the whole process. Signed-off-by: Dylan Reid <[email protected]>
rbradford
approved these changes
Jun 3, 2026
rbradford
enabled auto-merge
June 3, 2026 19:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We saw some seccomp violations when the tz cache was dropped. manually cache it before enforcing seccomp so that can't happen