ch-remote: Make snapshot and restore config arguments required - #8331
Merged
Merged
Conversation
likebreath
reviewed
Jun 4, 2026
likebreath
left a comment
Member
There was a problem hiding this comment.
Changes are looking good. But please remove the Change-Id from the commit message, as that's not meaningful for upstream code base. Thank you.
The snapshot and restore subcommands in ch-remote had optional snapshot_config and restore_config arguments, but the implementation was unconditionally unwrapping them. This change marks these arguments as required to handle the missing argument validation and report a proper error message instead of letting the application panic. Signed-off-by: Andrei Vagin <[email protected]>
server_api_error_display_modifier deserialized the JSON error response into a `Vec<&str>`. However, if the error message contained escaped characters, it could not deserialize it into a borrowed string `&str` because unescaping requires allocation. This resulted in a deserialization error and a failure to print the error chain. This change switches the deserialization target to `Vec<String>` to allow allocation. Signed-off-by: Andrei Vagin <[email protected]>
Contributor
Author
|
@likebreath Fixed. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The snapshot and restore commands in ch-remote had optional snapshot_config and restore_config arguments, but the implementation was unconditionally unwrapping them.
This change marks these arguments as required to handle the missing argument validation and report a proper error message instead of letting the application panic.