Conversation
sboeuf
approved these changes
Jun 11, 2026
rbradford
approved these changes
Jun 11, 2026
phip1611
reviewed
Jun 11, 2026
| } | ||
| }; | ||
|
|
||
| // Remove the external DMA mapping registered with the virtual IOMMU if |
Member
There was a problem hiding this comment.
nit: Not sure if this comment adds much value to the code
Currently ejecting a device leaks its mapping keeping the container fd open. Remove the mapping so the fd can be closed. Assisted-by: Claude:Opus-4.8 Signed-off-by: Dylan Reid <[email protected]>
dgreid
force-pushed
the
upstream/vfio-iommu-container-cleanup
branch
from
June 11, 2026 14:24
d88c70d to
82be0f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently ejecting a device leaks its mapping keeping the container fd open. Remove the mapping so the fd can be closed.
I don't have a great way to test this, so I'm going to lean on CI's vfio integration tests.