vmm: Replace asserts for checks on ACPI device accesses - #8405
Merged
rbradford merged 3 commits intoJun 17, 2026
Merged
Conversation
These devices should only be accessed by single byte accesses as specified through the ACPI definitions for them. Signed-off-by: Rob Bradford <[email protected]> Assisted-by: Claude:Opus-4.7
Reject without asserting that the ACPI PCI hotplug register request matches what is defined in the ACPI definition. Signed-off-by: Rob Bradford <[email protected]> Assisted-by: Claude:Opus-4.7
phip1611
reviewed
Jun 17, 2026
Reject without asserting that the ACPI CPU hotplug register accesses match those that are specified by the ACPI definitions. Signed-off-by: Rob Bradford <[email protected]> Assisted-by: Claude:Opus-4.7
rbradford
force-pushed
the
202606/device-access-checks
branch
from
June 17, 2026 12:48
74ff582 to
1cbbf1f
Compare
rbradford
enabled auto-merge
June 17, 2026 12:48
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the asserts which will cause the VMM to exit (semi-cleanly via panic handler) with warnings. A correctly behaving guest will never trigger these as it should respect the ACPI definitions over how to access these registers.