devices: fw_cfg: Correctly handle short and long reads - #8507
Merged
rbradford merged 1 commit intoJul 1, 2026
Merged
Conversation
Fill the target MMIO buffer with zeroes to handle reads with access sizes larger than the data and also check that the read access length does not exceed the size of the backing slice (previously it just checked the access size vs length not taking the offset into account). Assisted-by: Claude:Opus-4.8 Signed-off-by: Rob Bradford <[email protected]>
likebreath
approved these changes
Jul 1, 2026
rbradford
enabled auto-merge
July 1, 2026 16:56
Contributor
|
Hi, this is good catch. I suspect that this issue is common for all BusDevice implementation ? If so, the logic should go to the common implementation in BusDevice trait. If we would go for that route, it would be a big surger. So we can merge this patch first and create an issue for the future task, maybe for the next cycle. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fill the target MMIO buffer with zeroes to handle reads with access
sizes larger than the data and also check that the read access length
does not exceed the size of the backing slice (previously it just
checked the access size vs length not taking the offset into account).
Assisted-by: Claude:Opus-4.8
Signed-off-by: Rob Bradford [email protected]