virtio-devices: net: offer VIRTIO_NET_F_GUEST_ANNOUNCE to guests - #8521
Merged
rbradford merged 1 commit intoJul 3, 2026
Merged
Conversation
The virtio-net guest announce feature bit was accidentally dropped during upstreaming, so the device never advertised it to guests. Restore the feature offer for virtio-net. On-behalf-of: SAP [email protected] Signed-off-by: Sebastian Eydam <[email protected]>
phip1611
approved these changes
Jul 3, 2026
phip1611
left a comment
Member
There was a problem hiding this comment.
I can confirm that this line was missing and that with this line, GARP-packages (+ RARP packages) are discovered by our internal test suite and without it, only RARP packages. Thanks for fixing!
Super nit: per spec, VIRTIO_NET_F_GUEST_ANNOUNCE needs VIRTIO_NET_F_CTRL_VQ - If we ever make VIRTIO_NET_F_CTRL_VQ optional for whatever reason, we must make sure that VIRTIO_NET_F_GUEST_ANNOUNCE is also not advertised. No need to change it here but I want to raise awareness.
Member
|
Nice - I have a local change for this too. My local version also gates setting the |
rbradford
approved these changes
Jul 3, 2026
rbradford
enabled auto-merge
July 3, 2026 13:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This restores
VIRTIO_NET_F_GUEST_ANNOUNCEin virtio-net feature advertisement. The bit was accidentally dropped during #8263, so guest never saw it offered.@phip1611 noticed the missing line (big thanks to him!)
We backported #8263 onto our Cyberus branch and ran our tests to make sure everything works.