vmm: Reject snapshot/migration if on-demand restore still active - #8556
Merged
likebreath merged 3 commits intoJul 8, 2026
Merged
likebreath merged 3 commits into
likebreath merged 3 commits into
Conversation
rbradford
commented
Jul 8, 2026
Member
- vmm: Record when the on-demand memory restore is done
- vmm: Error out on migration & snapshot if on-demand restoring
- tests: Add integration tests to snapshot after/during restore
In order to deny migration or snapshot when currently doing an on-demand restore it is necessary to track whether the prefaulting is completed. This is a proxy for on-demand restoring being completed as pages that have been restored by a userfaultfd request will excluded from the prefault set. Fixes: cloud-hypervisor#8525 Signed-off-by: Rob Bradford <[email protected]>
If there is an active on-demand restoration then reject any requests to migrate or snapshot this VM as the memory will not be available for the snapshot. Signed-off-by: Rob Bradford <[email protected]>
Check that we can make a successful snapshot (and restore it) after another restore. Also check that snapshot it refused until restore is complete. Assisted-by: Claude:Opus-4.8 Signed-off-by: Rob Bradford <[email protected]>
likebreath
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.