Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@cadams8238
Copy link

What does this PR do?

Fixes the regex in the max-len rule in the base eslint config

Where should the reviewer start?

Dealer's choice.

How has this been tested?

Tested locally

Any background context you want to provide?

I wanted to be able to use React Fragment shorthand syntax, but eslint wasn't having it. Updated eslint + plugins and then ran into this problem where the base.js file wouldn't load due to the invalid regex.

What are the relevant tickets?

None

How will this be deployed?

N/A

What picture best describes this PR (optional but encouraged)?

image

Is there a link to personal staging environment?

Nope

Developer Done List

  • Considered Security, Availability and Confidentiality

For the Reviewer:

By approving this PR, the reviewer acknowledges that they have checked all items in this done list.

Reviewer/Approval Done List

  • Tests Pass Locally
  • CI Build Passes
  • Verified README.md/RUNBOOK.md is updated
  • Verified changes are backward compatible
  • Reviewed impact to Security, Availability and Confidentiality (if issue found, add comments and request changes)

@cadams8238 cadams8238 self-assigned this Dec 2, 2019
@cadams8238 cadams8238 merged commit 951b467 into master Dec 2, 2019
@cadams8238 cadams8238 deleted the typoFix branch December 2, 2019 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants