Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@bradsimantel
Copy link

What does this PR do?

Removes the Cypress plugin and references to it in the test lint configuration.

Where should the reviewer start?

Anywhere you want!

How has this been tested?

I tested that this fixes the issues I encountered in GUI with yarn link.

Any background context you want to provide?

Removing Cypress from GUI, tests were failing the lint config expected Cypress to be there.

What are the relevant tickets?

GUILDS-31

How will this be deployed?

The version will be bumped in GUI.

What picture best describes this PR (optional but encouraged)?

Is there a link to personal staging environment?

Developer Done List

  • Tests Added/Updated
  • Updated README.md/RUNBOOK.md
  • Verified backward compatible
  • Verified database migrations will not be catastrophic
  • Considered Security, Availability and Confidentiality

For the Reviewer:

By approving this PR, the reviewer acknowledges that they have checked all items in this done list.

Reviewer/Approval Done List

  • Tests Pass Locally
  • CI Build Passes
  • Verified README.md/RUNBOOK.md is updated
  • Verified changes are backward compatible
  • Reviewed impact to Security, Availability and Confidentiality (if issue found, add comments and request changes)

@bradsimantel bradsimantel merged commit 1f6e4e0 into master Feb 19, 2020
@bradsimantel bradsimantel deleted the GUILDS-31 branch February 19, 2020 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants