-
Notifications
You must be signed in to change notification settings - Fork 40
Reduce Metrics Payload Size [2] #298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbylovas
reviewed
Mar 12, 2025
bbylovas
reviewed
Mar 20, 2025
bbylovas
previously approved these changes
Mar 20, 2025
jdhudson3
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
(Follow up to #295)
This PR reduces memory usage and payload size of the metrics-agent by stripping unneeded metadata from Kubernetes resources by default.
This data stripping was previously done after the resources were collected and stored in memory, now the agent removes unnecessary metadata before storing the resources in the cache (reducing the memory footprint and saving agent running costs! 🎉 ).
Another payload reducing effort is included in this PR where we no longer collect Kubernetes resources that have zero cost associated with them. Such as old Completed Jobs or ReplicaSets that have 0 active pods. @jdhudson3 Thank you!
Although every Cluster's impact may vary, the results we see on our test cluster's seems to be about a 40% reduction in payload size.
Where should the reviewer start?
k8s_stats.go
How should this be manually tested?
Deployed to several testing clusters
Any background context you want to provide?
Nope
Tested with and without ParseMetricsData enabled
What picture best describes this PR (optional but encouraged)?
What are the relevant Github Issues?
Developer Done List
For the Reviewer:
By approving this PR, the reviewer acknowledges that they have checked all items in this done list.
Reviewer/Approval Done List